tygrvault/pulsar
tygrvault/pulsar
Archived
4
2
Fork 0
Code Issues 20 Pull requests Projects 1 Releases Activity Actions

feat: discord rich presence #49

Merged
tygrdev merged 10 commits from feat/discord-rich-presence into main 2025-12-19 21:03:35 +01:00
Conversation 7 Commits 10 Files changed 5 +288 -24
insberr commented 2025-12-18 03:42:12 +01:00
Contributor
Copy link
No description provided.
discord rpc sorta working
Some checks failed
/ build (push) Failing after 2m0s
Details
9a4faa2a3e
insberr self-assigned this 2025-12-18 03:42:19 +01:00
insberr commented 2025-12-18 03:42:37 +01:00
Author
Contributor
Copy link

@wackery can you please implement the data: url stuff

@wackery can you please implement the data: url stuff
insberr commented 2025-12-18 03:45:20 +01:00
Author
Contributor
Copy link

Things that still need to be done:

  • Clearing the discord status when the song is paused, and then setting it back when the song plays again.
  • Seeking needs to update the timestamp bar in discord. yay hfgl
  • @wackery suggested an alternative to spawning a new thread every time we update the discord status (see code for comment on why we spawn threads. hfgl)
Things that still need to be done: - Clearing the discord status when the song is paused, and then setting it back when the song plays again. - Seeking needs to update the timestamp bar in discord. yay hfgl - @wackery suggested an alternative to spawning a new thread every time we update the discord status (see code for comment on why we spawn threads. hfgl)
tygrdev commented 2025-12-18 13:50:35 +01:00
Owner
Copy link

:fear:

:fear:
tygrdev commented 2025-12-18 13:52:19 +01:00
Owner
Copy link

it blocks??? that’s hilarious

it blocks??? that’s hilarious
insberr commented 2025-12-18 23:41:52 +01:00
Author
Contributor
Copy link

So when you make a request to update the discord status, it blocks until the discord api responds. which in most cases probably isnt a huge issue, except discord seems to take a few seconds to reply which has the entire main thread to be blocked waiting.

So when you make a request to update the discord status, it blocks until the discord api responds. which in most cases _probably_ isnt a huge issue, except discord seems to take a few seconds to reply which has the entire main thread to be blocked waiting.
👍 1
seeking fixes. play/resume clears/sets status back
Some checks failed
/ build (push) Failing after 2m15s
Details
5a39f17d31
logo placeholder until album images work
Some checks failed
/ build (push) Failing after 2m2s
Details
d280e59e8e
fine
Some checks failed
/ build (push) Has been cancelled
Details
4b0bbedc6a
insberr commented 2025-12-19 04:08:34 +01:00
Author
Contributor
Copy link

Apart from some [probably bad] code architecture and failing CI due to my awful rust understanding, everything is working except album images. We decided album images will be implemented in the future after/during lastfm integration.

Apart from some [probably bad] code architecture and failing CI due to my awful rust understanding, everything is working except album images. We decided album images will be implemented in the future after/during lastfm integration.
insberr changed title from WIP: feat: discord rich presence to feat: discord rich presence 2025-12-19 04:09:28 +01:00
wackery force-pushed feat/discord-rich-presence from 4b0bbedc6a
Some checks failed
/ build (push) Has been cancelled
Details
to d94f4c3faa
Some checks failed
/ build (push) Failing after 1m59s
Details
2025-12-19 04:10:16 +01:00 Compare
tygrdev force-pushed feat/discord-rich-presence from d94f4c3faa
Some checks failed
/ build (push) Failing after 1m59s
Details
to a8625f5369
Some checks are pending
/ build (push) Waiting to run
Details
2025-12-19 17:21:11 +01:00 Compare
feat: add debounce
Some checks failed
/ build (push) Failing after 1m59s
Details
d5644b9f2c
fix: linting
All checks were successful
/ build (push) Successful in 1m51s
Details
edb87f48b0
tygrdev approved these changes 2025-12-19 21:00:32 +01:00
tygrdev deleted branch feat/discord-rich-presence 2025-12-19 21:03:35 +01:00
tygrdev referenced this pull request from a commit 2025-12-19 21:03:37 +01:00
feat: discord rich presence (#49)
Commenting is not possible because the repository is archived.
Reviewers
No reviewers
wackery
tygrdev
Labels
Clear labels   
bug

Something isn't working

  
documentation

Improvements or additions to documentation

  
duplicate

This issue or pull request already exists

  
enhancement

New feature or request

  
help wanted

Extra attention is needed

  
invalid

This doesn't seem right

  
question

Further information is requested

  
wontfix

This will not be worked on

No labels
bug
documentation
duplicate
enhancement
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
insberr
3 participants
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
tygrvault/pulsar!49
No description provided.